ruby: Fix memory leak in AbstractController
Review Request #3088 - Created Sept. 2, 2015 and submitted
| Information | |
|---|---|
| Joel Hestness | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 11079:16c8f4c7dc34 --------------------------- ruby: Fix memory leak in AbstractController Recent changes to memory access queuing allocate requests for packets sent to memory controllers, but did not free the requests. Delete them to avoid leaks.
Posted (Sept. 2, 2015, 7:03 a.m.)
-
src/mem/ruby/slicc_interface/AbstractController.cc (Diff revision 1) -
Are there cases where this isn't true? When/why do we create a packet without a request?
Review request changed
Updated (Sept. 2, 2015, 9:36 a.m.)
Change Summary:
For Jason's point: There should be no locations that allocate packets without a request. A handful of tests indicate the conditional was unnecessary.
Description: |
|
|||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+1) |
Thanks for looking into that!
Ship It!