src/cpu/o3/probe/elastic_trace.hh (Diff revision 1)

Do we really need this?  I would rather always trace the virtual address as well.  I don't think there are any code correctness or clarity or performance gains to be made from this check.

Show all issues

1. Andreas Sandberg Dec. 1, 2015, 3:35 p.m. (Dec. 1, 2015, 3:35 p.m.)

   I haven't done the comparison, but my guess is that it'd grow the trace by about 10%. AFAIK, the protobuf format should be pretty good at handling unused fields. Besides, there are cases where the virtual address isn't meaningful (e.g., when tracing device accesses).
   Also, making virtual addresses mandatory would only really affect the probe. We would still have to handle the case where old traces don't contain them.

2. Radhika Jagtap Dec. 2, 2015, 10:44 a.m. (Dec. 2, 2015, 10:44 a.m.)

   The decision to make tracing virtual addresses as optional is because it is not used in majority of memory-system studies and as Andreas S pointed out it increases the size of the traces significantly.

3. Nilay Vaish Dec. 3, 2015, 12:17 p.m. (Dec. 3, 2015, 12:17 p.m.)

   Ok.

Ship It!