ruby: slicc: remove support for single machine, multiple types

Information
Submitter:	Tony Gutierrez
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 11275:35850e75c5f1
---------------------------
ruby: slicc: remove support for single machine, multiple types

This patch is imported from reviewboard patch 2550 by Nilay.
It was possible to specify multiple machine types with a single state machine.
This seems unnecessary and is being removed.

Testing Done

Please give this a real description. Why do we need to remove this functionality?

Sooraj Puthoor Nov. 12, 2015, 9:29 a.m. (Nov. 12, 2015, 9:29 a.m.)

This patch is the same as patch 2550 (reviews.gem5.org/r/2550/). So, would it help if we use the same description used in that patch for this patch also? According to patch 2550, this functionality was removed becasue it is unnecessary to have this functionality.

Sooraj Puthoor Nov. 20, 2015, 12:18 p.m. (Nov. 20, 2015, 12:18 p.m.)
```
Will update patch description in the next revision of this patch
```

Nilay Vaish Nov. 21, 2015, 8:20 p.m. (Nov. 21, 2015, 8:20 p.m.)

Most likely (unless you come up with an alternative) you will have to drop this patch since MOESI Hammer uses the multiple machines types in single declaration functionality.

Tony Gutierrez Dec. 24, 2015, 12:03 p.m. (Dec. 24, 2015, 12:03 p.m.)

That usage is not necessary. The patch has been updated to remove multi types from MOESI_hammer-cache.sm. All regressions pass.

Summary:

-	ruby: imported from reviewboard patch 2550
+	ruby: slicc: remove support for single machine, multiple types

Description:

~		Changeset 11182:2b48ac25cf2f
	~	Changeset 11276:b3daf37c5620

~		ruby: imported from reviewboard patch 2550
	~	ruby: slicc: remove support for single machine, multiple types

~		filename temp_nilay_rm_multi_machtypes.patch
	~	This patch is imported from reviewboard patch 2550 by Nilay.
	+	It was possible to specify multiple machine types with a single state machine.
	+	This seems unnecessary and is being removed.

Diff:

Revision 2 (+10 -17)

Show changes

	src/mem/slicc/parser.py
	src/mem/slicc/ast/MachineAST.py

Description:

~		Changeset 11276:b3daf37c5620
	~	Changeset 11275:35850e75c5f1

		ruby: slicc: remove support for single machine, multiple types

		This patch is imported from reviewboard patch 2550 by Nilay.
		It was possible to specify multiple machine types with a single state machine.
		This seems unnecessary and is being removed.

Diff:

Revision 3 (+11 -18)

Show changes

	src/mem/protocol/MOESI_hammer-cache.sm
	src/mem/slicc/parser.py
	src/mem/slicc/ast/MachineAST.py

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Summary:

Description:

Changeset 11182:2b48ac25cf2f

Changeset 11276:b3daf37c5620

Diff:

Description:

Changeset 11276:b3daf37c5620

Changeset 11275:35850e75c5f1

Diff:

Status: Closed (submitted)