config, x86: Properly space pad the X86IntelMPBus Entry descriptions.
Review Request #3194 - Created Nov. 4, 2015 and submitted
| Information | |
|---|---|
| Bjoern A. Zeeb | |
| gem5 | |
| dev | |
| Reviewers | |
| Default | |
| powerjg, stever | |
According to the Intel Multi Processor Specification rev 1.4 (-006) (*), section 4.3.2 Bus Entries, Bus type strings are >>6-character ASCII (blank-filled) strings<<. Properly pad the entries with the missing spaces at the end. (*) http://www.intel.com/design/pentium/datashts/24201606.pdf
Booting FreeBSD in FS mode no longer complains about unknown busses "PCI" and "ISA".
-
src/arch/x86/bios/IntelMP.py (Diff revision 2) -
This is a comment. I don't see how changing it helps. I would rather add the "6 byte" comment near the changes made to FSConfig.py. Also should we add a check in the corresponding c++ class?
One moer thing. Please confirm that x86 full system regression tests pass
with this change.
Change Summary:
Update diff. Be careful given the "whitespace only" changes in FSConfig.py are the actual changes!
Diff: |
Revision 3 (+3 -3) |
|---|
Seems fine to me. The linux kernel I'm using boots correctly with the change.
In the future, make sure you use one of the keywords in the first line of the description (The keyword should be one or more of the following separated by commas: base, ext, stats, sim, syscall_emul, config, ruby, mem, cpu, gpu-compute, dev, energy, arch, arm, x86, alpha, mips, power, sparc, kvm, scons, tests, misc, style. From http://gem5.org/Submitting_Contributions#Creating_Patches). I think "config" is probably the right one for this patch.
Thanks!