mem: write combining for ruby protocols

Information
Submitter:	Tony Gutierrez
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 11193:81764d4f4aa4
---------------------------
ruby: support for per-byte dirty bits.

This patch enables ruby to model write-combining caches (e.g., GPU-Viper).

Testing Done

I am a bit confused as the patch seems contain parts of the functionality needed to enable dirty bits per byte, but no write combining of uncacheable writes. The description definitely needs to be updated, and at the moment the diff also seems very incomplete.

Marc Orr Jan. 4, 2016, 1:57 p.m. (Jan. 4, 2016, 1:57 p.m.)

Hi Andreas. You are correct, this patch adds functionality for ruby protocols to enable dirty bits per byte.

It was developed to model write-combining caches in ruby. For example, see
src/mem/protocol/GPU_VIPER-TCP.sm
http://reviews.gem5.org/r/3189/diff/2/?page=7#35

src/mem/protocol/GPU_VIPER-TCC.sm
http://reviews.gem5.org/r/3189/diff/2/?page=6#85

How about the following update the description:

ruby: support for per-byte dirty bits.

This patch enables ruby to model write-combining caches (e.g., GPU-Viper).

Description:

~		Changeset 11193:81764d4f4aa4
	~	Changeset 11193:81764d4f4aa4
	+	---------------------------
	+	ruby: support for per-byte dirty bits.

~		mem: write combining for ruby protocols
	~	This patch enables ruby to model write-combining caches (e.g., GPU-Viper).
-
-		This patch adds support for write-combining in ruby.

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Description:

Changeset 11193:81764d4f4aa4

Status: Closed (submitted)