mem: remove acq/rel cmds from packet and add mem fence req

Information
Submitter:	Tony Gutierrez
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 11221:5ab3135651f9
---------------------------
mem: remove acq/rel cmds from packet and add mem fence req

The separate, and specific Acq/Rel commands are not needed, however a generic MemFence req/resp is added.

Testing Done

Summary:

-	mem: remove aqcuire/release cmd from packet
+	mem: remove acq/rel cmds from packet and add mem fence req

Description:

~		Changeset 11221:4e4c63b9c391
	~	Changeset 11221:5ab3135651f9
	+	---------------------------
	+	mem: remove acq/rel cmds from packet and add mem fence req

~		mem: remove aqcuire/release cmd from packet
	~	The separate, and specific Acq/Rel commands are not needed, however a generic MemFence req/resp is added.

Diff:

Revision 2 (+6 -12)

Show changes

	src/mem/packet.hh
	src/mem/packet.cc

No objections...but could you give a hint as to how they will be used?

Tony Gutierrez Dec. 7, 2015, 5:09 p.m. (Dec. 7, 2015, 5:09 p.m.)

These are currently used by packets that encapsulate acq/rel requests. Instead of using specific acq/req cmds, which are redundant and unnecessary as you previously pointed out, we use this MemFence cmd which is mean to be a generic sync cmd, and should be reusable by any other sync type requests.

Andreas Hansson Dec. 8, 2015, 12:28 a.m. (Dec. 8, 2015, 12:28 a.m.)

Hmm, ok. So for now this is intended for acquire and release only? What further scope do you envision? Are there any existing operations that could also be using this?

Tony Gutierrez Dec. 9, 2015, 1 p.m. (Dec. 9, 2015, 1 p.m.)

I think e.g., in ARM's case, this could be reused by DMB, LdX/StX, etc., instructions if you wanted to actually send of sync requests to the memory system. As I understand it now, all of these are handled by the instructon itself through the ISA interface.

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Summary:

Description:

Changeset 11221:4e4c63b9c391

Diff:

Status: Closed (submitted)