sim: Add an option to forward work items to Python
Review Request #3244 - Created Dec. 4, 2015 and submitted
| Information | |
|---|---|
| Andreas Sandberg | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 11240:b7f2abdbce1a --------------------------- sim: Add an option to forward work items to Python There are cases where we want the Python world to handle work items instead of the C++ world. However, that's currently not possible. This changeset adds the forward_work_items option to the System class. Then it is set to True, work items will generate workbegin/workend simulation exists with the work item ID as the exit code and the old C++ handling is completely bypassed.
I think this is the way it should have been!
I know I'm a bit late in reviewing this patch and it is already checked in, but could you please make the following change below. Thanks!
-
src/sim/System.py (Diff revision 1) -
Why make this default true? This changes the behavior of the simulator and now for those apps that are annotated with work_ends, the simulation stops as soon as the first annotation is encountered. Furthermore, it is not obvious that the simulation ends because the first annotation was encountered rather than the application reaches completion.
Please revert back to the old behavior. It makes a lot more sense that by default, gem5 will execute the entire application and only stops prematurely if the user explicitly asks to exit when work items are encountered.