mem: Expose memory bandwidth and latency for SimpleMemory

Information
Submitter:	Matthew Poremba
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 11310:8ddcef48674b
---------------------------
mem: Expose memory bandwidth and latency for SimpleMemory

Expose SimpleMemory bandwidth and latency parameters to the command line.
This allows for easier simulation of fixed latency memory controllers to
facilitate simple limit-study investigations.

Testing Done

Issue Summary

Description	From	Last Updated	Status
elif	Tony Gutierrez	Jan. 21, 2016, 5:03 p.m.	Resolved
elif	Tony Gutierrez	Jan. 21, 2016, 5:03 p.m.	Resolved

I am not massively thrilled, but our current config system definitely has some challenges. The biggest issue here is that the options only apply to a very specific instance of the memory controller, and I see how users may get confused. If you want to go down this route we should at least check and warn if the values are not used. Also, how does it interact with a multi-channel memory? Lastly, the existing memory command-line options are "mem" and not "memory".

Matthew Poremba Jan. 21, 2016, 3:56 p.m. (Jan. 21, 2016, 3:56 p.m.)

I added the warns as you suggested and i'm willing to go with an even more verbose option name if necessary (e.g., --simple-mem-latency/bandwidth).

For multiple memory channels, each channel will use the same parameter values specified by these options.

Change Summary:

Added warns when options are used with non-SimpleMemory classes. Move MemConfig lines above elastic trace setup (elastic trace trumps).

Description:

~		Changeset 11296:d04dae0d7ec3
	~	Changeset 11310:df69dd6ec6fc
		---------------------------
		mem: Expose memory bandwidth and latency for SimpleMemory

		Expose SimpleMemory bandwidth and latency parameters to the command line.
		This allows for easier simulation of fixed latency memory controllers to
		facilitate simple limit-study investigations.

Diff:

Revision 2 (+33 -1)

Show changes

	configs/common/MemConfig.py
	configs/common/Options.py
	configs/ruby/Ruby.py

configs/common/MemConfig.py (Diff revision 2)

elif

Show all issues

configs/ruby/Ruby.py (Diff revision 2)

elif

Show all issues

Description:

~		Changeset 11310:df69dd6ec6fc
	~	Changeset 11310:8ddcef48674b
		---------------------------
		mem: Expose memory bandwidth and latency for SimpleMemory

		Expose SimpleMemory bandwidth and latency parameters to the command line.
		This allows for easier simulation of fixed latency memory controllers to
		facilitate simple limit-study investigations.

Diff:

Revision 3 (+31 -1)

Show changes

	configs/common/MemConfig.py
	configs/common/Options.py
	configs/ruby/Ruby.py

You have a pending review.

Review Board 2.0.15

This change has been discarded.

Screenshots

Files

Issue Summary

Change Summary:

Description:

Diff:

Description:

Diff:

Status: Discarded