ruby: Make MessageBuffers actually finite sized
Review Request #3283 - Created Jan. 17, 2016 and submitted - Latest diff uploaded
| Information | |
|---|---|
| Joel Hestness | |
| gem5 | |
| default | |
| 3753, 3752 | |
| Reviewers | |
| Default | |
Changeset 11298:1af0000a8d03 --------------------------- ruby: Make MessageBuffers actually finite sized When Ruby controllers stall messages in MessageBuffers, the buffer moves those messages off the priority heap and into a per-address stall map. When buffers are finite-sized, the test areNSlotsAvailable() only checks the size of the priority heap, but ignores the stall map, so the map is allowed to grow unbounded if the controller stalls numerous messages. This patch fixes the problem by tracking the stall map size and testing the total number of messages in the buffer appropriately.
Multiple tests to exercise the capacity of buffers, including high bandwidth
demand and MLP situations concurrently accessing numerous different line
addresses. Regressions are unchanged, since they do not use finite-sized
buffering.NOTE: When using finite-sized buffers, this fix can cause decreased
performance due to insufficient buffering, a condition that was masked with
the unbounded stall map. Users may need to adjust buffer sizes to revalidate
performance.
