gpu-compute: fix uninitialized value error.

Information
Submitter:	Marc Orr
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 11348:d879687daa1c
---------------------------
gpu-compute: fix uninitialized value error.

I came across this uninitialized value error, while running the gpu-compute
model inside valgrind.

Testing Done

Issue Summary

Description	From	Last Updated	Status
if (mask\[lane\] && m->addr\[lane\] < w->privSizePerItem)? Or am I missing something here?	Jason Lowe-Power	Feb. 25, 2016, 1:26 p.m.	Resolved

Ship It!

It would be good if someone could run this with ubsan and asan.

Also, if we all agree that 'gpu-compute' is indeed the most sensible keyword we should add it to the list. Something shorted and snappier would be nice, but I guess gpgpu, apu are not favoured?

Marc Orr Feb. 25, 2016, 1:18 p.m. (Feb. 25, 2016, 1:18 p.m.)

Thanks for suggesting to run the santizers, though I'll assume that's not required to check this in :-).

Concerning 'gpu-compute,' I simply followed the wiki:
http://www.gem5.org/Submitting_Contributions

"The keyword should be one or more of the following separated by commas: base, ext, stats, sim, syscall_emul, config, ruby, mem, cpu, gpu-compute, dev, energy, arch, arm, x86, alpha, mips, power, sparc, kvm, scons, tests, misc, style."

Andreas Hansson Feb. 26, 2016, 9:34 a.m. (Feb. 26, 2016, 9:34 a.m.)

So it is in the list. Good.

I am merely suggesting to run the sanitizers to catch any other issues instead of fixing them one by one.

src/arch/hsail/insts/mem_impl.hh (Diff revision 1)

if (mask[lane] && m->addr[lane] < w->privSizePerItem)?
Or am I missing something here?

Show all issues

Marc Orr Feb. 25, 2016, 1:16 p.m. (Feb. 25, 2016, 1:16 p.m.)

Sure..., I can move the nested if into the first-level if. Doesn't make much difference to me :-).

Description:

~		Changeset 11348:01a0e9fbaad4
	~	Changeset 11348:d879687daa1c

		gpu-compute: fix uninitialized value error.

		I came across this uninitialized value error, while running the gpu-compute
		model inside valgrind.

Diff:

Revision 2 (+8 -10)

Show changes

src/arch/hsail/insts/mem_impl.hh

Thanks! That looks better now :)

You have a pending review.

Review Board 2.0.15

Screenshots

Files

Issue Summary

Description:

Changeset 11348:01a0e9fbaad4

Changeset 11348:d879687daa1c

Diff: