Review Board 2.0.15


gpu-compute: fix gpu memfence

Review Request #3338 - Created Feb. 22, 2016 and updated

Information
Marc Orr
gem5
default
Reviewers
Default
Changeset 11349:f14a633b3ac8
---------------------------
gpu-compute: fix gpu memfence

Memory fence instructions were incorrectly annotated to indicate that they were
initiated on a kernel launch/end. This patch correctly annotates an explicit
memory fence.

   

Issue Summary

1 1 0 0
Ship it!
Posted (Feb. 22, 2016, 5:12 p.m.)
Ship It!
Posted (Feb. 23, 2016, 6:58 a.m.)



  
src/gpu-compute/compute_unit.hh (Diff revision 1)
 
 

From what I can tell on a cursory grep there are no places where you call this without a req. Is this true? If so, you should remove the default there too.

  1. It is called without req, up above in the same file... In any case, I would be up for getting rid of the default value here.

    Side note: I was a little premature in posting this... I'm spending a little more time to confirm that I did this correctly. I hope to either update the patch or this comment next week.