Review Board 2.0.15


misc: Add support for switching multiple cores in SystemC

Review Request #3360 - Created March 4, 2016 and updated

Information
Paul Rosenfeld
gem5
default
Reviewers
Default
Changeset 11763:0b76489963ee
---------------------------
misc: Add support for switching multiple cores in SystemC

This patch adds a '-n' flag to the gem5 SystemC driver which allows
multiple CPUs to be switched out to a new CPU. Primarily this involves
appending CPU numbers to the objects searched for in the config
manager if there are multiple CPUs in the system.

Note that an equivalent change should be made to the util/cxx_config driver,
but I wanted to get input on this first before making the same change over
there

   
Review request changed
Updated (Dec. 16, 2016, 8:24 a.m.)

Description:

~  

Changeset 11364:10d215092e90

  ~

Changeset 11763:0b76489963ee

   
   

misc: Add support for switching multiple cores in SystemC

   
   

This patch adds a '-n' flag to the gem5 SystemC driver which allows

    multiple CPUs to be switched out to a new CPU. Primarily this involves
    appending CPU numbers to the objects searched for in the config
    manager if there are multiple CPUs in the system.

   
   

Note that an equivalent change should be made to the util/cxx_config driver,

    but I wanted to get input on this first before making the same change over
    there

Diff:

Revision 2 (+61 -11)

Show changes

Ship it!
Posted (Jan. 17, 2017, 11:47 a.m.)

Seems OK to me, although I don't use the System C interface. Do any others have any feedback? If I don't hear anything by Friday, I'm going to push.

(There's some minor formatting issues, but I'll take care of it before I push, and I'll update the comment below unless I hear otherwise.)

util/systemc/main.cc (Diff revision 2)
 
 

I believe it cannot be called before old_cpu.switchOut(). takeOverFrom() assumes the system state is "Drained", which happens during switchOut() IIRC.

Ship it!
Posted (Jan. 19, 2017, 3:08 a.m.)
Ship It!
Ship it!
Posted (Jan. 19, 2017, 1:40 p.m.)
Ship It!