mem : tester for new HMC configuration

Information
Submitter:	Abdul Mutaal Ahmad
Repository:	gem5
Branch:
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

This patch provides the example test script to configure different HMC architecture and run traffic through traffic generator.

Testing Done

To run, it requires the main HMC config patch 
http://reviews.gem5.org/r/3373/
===============

How to run it

===============

from you gem5 home directory run the following commands
build/ARM/gem5.opt configs/example/hmctest.py --mem-type=HMC_2500_x32 --mode=RANDOM  --arch=same

build/ARM/gem5.opt configs/example/hmctest.py --mem-type=HMC_2500_x32 --mode=RANDOM  --arch=distributed

build/ARM/gem5.opt configs/example/hmctest.py --mem-type=HMC_2500_x32 --mode=RANDOM  --arch=mixed

Issue Summary

Description	From	Last Updated	Status
Update the comment.	Stephan Diestelhorst	May 19, 2016, 5:49 a.m.	Resolved
there should be a space aroudn the "=", also in similar locations furhter down	Stephan Diestelhorst	May 19, 2016, 5:49 a.m.	Resolved
what is the difference between DRAM and RANDOM?	Stephan Diestelhorst	June 29, 2016, 4:50 a.m.	Resolved
I think this can be turned into a look indexing into an array.	Stephan Diestelhorst	June 29, 2016, 4:50 a.m.	Resolved
Which range was that? Add this to the comment. Distributed range accross links.	Stephan Diestelhorst	May 19, 2016, 5:49 a.m.	Resolved
"Mixed" address distribution over links.	Stephan Diestelhorst	May 19, 2016, 5:49 a.m.	Resolved
what happens if arch==0?	Stephan Diestelhorst	June 29, 2016, 4:50 a.m.	Resolved
why are you only wiring up half the testers in this case?	Stephan Diestelhorst	June 29, 2016, 4:50 a.m.	Resolved
what happens if arch==0?	Stephan Diestelhorst	June 29, 2016, 4:49 a.m.	Resolved
How about making the arch also more readable: type = string, choices = 'same', 'distributed', 'mix-same-dist'? Will be much better ...	Radhika Jagtap	June 29, 2016, 4:29 a.m.	Resolved
Can you make the mem ranges more readable and in a loop (e.g. 256 * 1024 * 1024)?	Radhika Jagtap	June 29, 2016, 4:29 a.m.	Resolved
Same here, can you make the mem ranges more readable?	Radhika Jagtap	June 29, 2016, 4:29 a.m.	Resolved

Testing Done:

		To run, it requires the main HMC config patch

	+	http://reviews.gem5.org/r/3373/
	+
		===============
		How to run it
		===============
		from you gem5 home directory run the following commands

		build/ARM/gem5.opt configs/example/hmctest.py --mem-type=HMC_2500_x32 --mode=RANDOM --arch=0
		build/ARM/gem5.opt configs/example/hmctest.py --mem-type=HMC_2500_x32 --mode=RANDOM --arch=1
		build/ARM/gem5.opt configs/example/hmctest.py --mem-type=HMC_2500_x32 --mode=RANDOM --arch=2

Change Summary:

Tester is updated for new revision of patch. It considers a 4GB HMC device with 16 vault controller.

Diff:

Revision 2 (+183)

Show changes

	configs/example/hmctest.py
	tests/quick/se/70.tgen/traffic.cfg

configs/example/hmctest.py (Diff revision 2)

Update the comment.

Show all issues

Abdul Mutaal Ahmad May 18, 2016, 7:36 a.m. (May 18, 2016, 7:36 a.m.)
```
Okay. Agree
```

configs/example/hmctest.py (Diff revision 2)

there should be a space aroudn the "=", also in similar locations furhter down

Show all issues

Abdul Mutaal Ahmad May 18, 2016, 7:36 a.m. (May 18, 2016, 7:36 a.m.)
```
Thanks. Agree
```

configs/example/hmctest.py (Diff revision 2)

what is the difference between DRAM and RANDOM?

Show all issues

Abdul Mutaal Ahmad May 18, 2016, 7:36 a.m. (May 18, 2016, 7:36 a.m.)

This is a traffic generator mode used in /cpu/testers/traffic_gen.cc:278 . It was kept here if we want to generate a custom traffic using this script. However, I alredy have a traffic.cfg included in the script.

configs/example/hmctest.py (Diff revision 2)

I think this can be turned into a look indexing into an array.

Show all issues

configs/example/hmctest.py (Diff revision 2)

Which range was that? Add this to the comment. Distributed range accross links.

Show all issues

Abdul Mutaal Ahmad May 18, 2016, 7:36 a.m. (May 18, 2016, 7:36 a.m.)
```
Thanks. Agreed
```

configs/example/hmctest.py (Diff revision 2)

"Mixed" address distribution over links.

Show all issues

Abdul Mutaal Ahmad May 18, 2016, 7:36 a.m. (May 18, 2016, 7:36 a.m.)
```
Thanks. Agreed
```

configs/example/hmctest.py (Diff revision 2)

what happens if arch==0?

Show all issues

Abdul Mutaal Ahmad May 18, 2016, 7:36 a.m. (May 18, 2016, 7:36 a.m.)

In this case, I am using the system.mem_ranges in HMC.py. I can also write a case for arch-0 .

configs/example/hmctest.py (Diff revision 2)

why are you only wiring up half the testers in this case?

Show all issues

Abdul Mutaal Ahmad May 18, 2016, 7:36 a.m. (May 18, 2016, 7:36 a.m.)

because the other 2 testers are directly connected to serial links in HMC.py. That is what hybrid supposed to do.

configs/example/hmctest.py (Diff revision 2)

what happens if arch==0?

Show all issues

Abdul Mutaal Ahmad May 18, 2016, 7:36 a.m. (May 18, 2016, 7:36 a.m.)

arch0 has the direct connection to serial links. It is done in HMC.py

Thanks for getting this out. There are still a few small things that need adressing.

Change Summary:

modifications to improve code readability

Diff:

Revision 3 (+186)

Show changes

	configs/example/hmctest.py
	tests/quick/se/70.tgen/traffic.cfg

Change Summary:

Added ranges of serial link for all architecutres

Diff:

Revision 4 (+192)

Show changes

	configs/example/hmctest.py
	tests/quick/se/70.tgen/traffic.cfg

configs/example/hmctest.py (Diff revision 4)

How about making the arch also more readable: type = string, choices = 'same', 'distributed', 'mix-same-dist'? Will be much  better for readability, debugging, hackability..

Show all issues

configs/example/hmctest.py (Diff revision 4)

Can you make the mem ranges more readable and in a loop (e.g. 256 * 1024 * 1024)?

Show all issues

configs/example/hmctest.py (Diff revision 4)

Same here, can you make the mem ranges more readable?

Show all issues

Change Summary:

Improved readability of code

Testing Done:

		To run, it requires the main HMC config patch

		http://reviews.gem5.org/r/3373/

		===============
		How to run it
		===============
		from you gem5 home directory run the following commands

~		build/ARM/gem5.opt configs/example/hmctest.py --mem-type=HMC_2500_x32 --mode=RANDOM --arch=0
~		build/ARM/gem5.opt configs/example/hmctest.py --mem-type=HMC_2500_x32 --mode=RANDOM --arch=1
~		build/ARM/gem5.opt configs/example/hmctest.py --mem-type=HMC_2500_x32 --mode=RANDOM --arch=2
	~	build/ARM/gem5.opt configs/example/hmctest.py --mem-type=HMC_2500_x32 --mode=RANDOM --arch=same
	~	build/ARM/gem5.opt configs/example/hmctest.py --mem-type=HMC_2500_x32 --mode=RANDOM --arch=distributed
	~	build/ARM/gem5.opt configs/example/hmctest.py --mem-type=HMC_2500_x32 --mode=RANDOM --arch=mixed

Diff:

Revision 5 (+177)

Show changes

	configs/example/hmctest.py
	tests/quick/se/70.tgen/traffic.cfg

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Testing Done:

Change Summary:

Diff:

Change Summary:

Diff:

Change Summary:

Diff:

Change Summary:

Testing Done:

Diff:

Status: Closed (submitted)