SConstruct (Diff revision 1)

i am surprised to not see this change in util/regress as well
should we parametrise the name rather?

Show all issues

1. Bjoern A. Zeeb April 5, 2016, 7:18 a.m. (April 5, 2016, 7:18 a.m.)

   Are you thinking about tests/SConscript maybe?

2. Andreas Hansson April 9, 2016, 2:37 a.m. (April 9, 2016, 2:37 a.m.)

   Yes, you're absolutely right.

SConstruct (Diff revision 1)

should we just replace the check for message.h rather?

Show all issues

1. Bjoern A. Zeeb April 5, 2016, 7:18 a.m. (April 5, 2016, 7:18 a.m.)

   Seems with a recent library version the extra check is no longer needed.

SConstruct (Diff revision 2)

Surely this is included by default?!

Show all issues

1. Bjoern A. Zeeb May 31, 2016, 6:49 a.m. (May 31, 2016, 6:49 a.m.)

   clang -cc1 -v /dev/null
   
   clang -cc1 version 3.4.1 based upon LLVM 3.4.1 default target x86_64-unknown-freebsd10.3
   
   ignoring nonexistent directory "/usr/lib/clang/3.4.1/include"
   include "..." search starts here:
   include <...> search starts here:
   /usr/include/clang/3.4.1
   
    /usr/include
   
   End of search list.

2. Andreas Hansson May 31, 2016, 7:09 a.m. (May 31, 2016, 7:09 a.m.)

   Is the compiler configured/installed properly? I've had a look at gcc and clang on a few OSX/Linux permutations and /usr/local/include is listed for all of them.

3. Bjoern A. Zeeb May 31, 2016, 7:39 a.m. (May 31, 2016, 7:39 a.m.)

   Yes, it's the built-in compiler from the FreeBSD base system.  I just triple-checked with people; it is on purpose;  the FreeBSD ports framework does add a -I${LOCALBASE}/include already, but building gem5 alone, it needs the extra include.

SConstruct (Diff revision 2)

could we not make TIMEOUT contain the command rather, and then use it in tests/SConscript?

Show all issues

Ship It!

Ship It!

SConstruct (Diff revision 3)

Before committing this, could you add a comment before this line to explain that is is for BSD?

Show all issues

Ship It!