scons: Automatically install the git style hook
Review Request #3386 - Created March 16, 2016 and submitted
| Information | |
|---|---|
| Andreas Sandberg | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 11379:dc2c6465e7d9 --------------------------- scons: Automatically install the git style hook Add a check in the main SConscript that installs the git pre-commit hook in util/ if git is used. Signed-off-by: Andreas Sandberg <andreas.sandberg@arm.com> Reviewed-by: Curtis Dunham <curtis.dunham@arm.com>
-
SConstruct (Diff revision 1) -
For consistency, how about this:
style_message = """
You're missing the gem5 style hook, which automatically checks your code
against the gem5 style rules when committing changes. This
script will now install the hook in your %s.
Press enter to continue, or ctrl-c to abort: """mercurial_style_message = style_message % ".hg/hgrc file"
git_style_message = style_message % ".git/hooks/ directory" -
SConstruct (Diff revision 1) -
this comment should be refactored to better match the new code structure
Description: |
|
||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+35 -5) |
-
SConstruct (Diff revision 2) -
should be 'style_message'?
Description: |
|
||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+36 -6) |
Ship It!