Add mc2lib to ext/
Review Request #3448 - Created April 13, 2016 and updated
| Information | |
|---|---|
| Marco Elver | |
| gem5 | |
| default | |
| 3449 | |
| Reviewers | |
| Default | |
Add mc2lib to ext/
This is the simulator-independent component for McVerSi.
Source: https://github.com/melver/mc2lib
Together with http://reviews.gem5.org/r/3449/
Issue Summary
| Description | From | Last Updated | Status |
|---|---|---|---|
| does x86 support flushing? both classic and ruby? | Andreas Hansson | June 4, 2016, 8:50 a.m. | Open |
| should we just get it done rather? | Andreas Hansson | June 4, 2016, 7:46 a.m. | Open |
Could you make sure that every file that is added has an appropriate license header?
You may want to exclude some files that are not needed...
Change Summary:
Update from upstream.
Confimed working with minimum GCC 4.7 and Clang 3.2.
Diff: |
Revision 5 (+7161) |
|---|
Looks good. Two questions: First, how about the compile-time constants through #defines. Is there a way we can make these run-time configurable? The cacheline size is one prime example. Second, there still appears to be files without a license header.
-
ext/mc2lib/contrib/mcversi/m5_host_support.h (Diff revision 5) -
Is there any way we could make these non-compile time constants? Ultimately it would be good if all of these was parameters for the wrapper.
-
ext/mc2lib/contrib/mcversi/m5_host_support.h (Diff revision 5) -
does x86 support flushing? both classic and ruby?
-
ext/mc2lib/contrib/mcversi/m5_host_support.h (Diff revision 5) -
should we just get it done rather?
-
ext/mc2lib/contrib/mcversi/run-10-8KB.sh (Diff revision 5) -
Technically all of these need a license header.
