misc: Appease clang-3.4.1
Review Request #3454 - Created April 26, 2016 and discarded
| Information | |
|---|---|
| Pierre-Yves Péneau | |
| gem5 | |
| master | |
| Reviewers | |
| Default | |
Appease clang-3.4.1
Fresh install of FreeBSD 10.3-RELEASE (i386), default clang compiler (3.4.1)
Review request changed
Updated (April 26, 2016, 10:56 a.m.)
Status: Re-opened
Diff: |
Revision 1 (+1 -1) |
|---|
Review request changed
Updated (April 26, 2016, 11:02 a.m.)
Summary: |
|
|||
|---|---|---|---|---|
Description: |
|
Posted (April 26, 2016, 1:54 p.m.)
This was fixed in HEAD after I noticed that we aren't spec compliant; but older versions indeed need the cast.
I am currently using at least an #ifdef here:
--- a/src/sim/init_signals.cc Tue Apr 05 08:08:12 2016 -0500
+++ b/src/sim/init_signals.cc Tue Apr 26 20:51:26 2016 +0000
@@ -66,7 +66,11 @@
setupAltStack()
{
stack_t stack;
+#ifdef __FreeBSD__
+ stack.ss_sp = (char *)fatalSigStack;
+#else
stack.ss_sp = fatalSigStack;
+#endif
stack.ss_size = sizeof(fatalSigStack);
stack.ss_flags = 0;
But for the FreeBSD block we almost also need to check __FreeBSD_version >= 11xxxxxx but I haven't done the due diligence yet what the exact version number should be.