cpu: Physical register structural + flat indexing
Review Request #3458 - Created April 28, 2016 and updated
| Information | |
|---|---|
| Andreas Sandberg | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 11465:2d28d7045050 --------------------------- cpu: Physical register structural + flat indexing Mimic the changes done on the architectural register indexes on the physical register indexes. This is specific to the O3 model. The structure, called PhysRegId, contains a register class, a register index and a flat register index. The flat register index is kept because it is useful in some cases where the type of register is not important (dependency graph and scoreboard for example). Instead of directly using the structure, most of the code is working with a const PhysRegId* (typedef to PhysRegIdPtr). The actual PhysRegId objects are stored in the regFile. Change-Id: Ic879a3cc608aa2f34e2168280faac1846de77667 Reviewed-by: Andreas Sandberg <andreas.sandberg@arm.com>
Posted (May 12, 2016, 9:22 p.m.)
Nice! Looks pretty straightforward, esp. compared to the previous patch...
-
src/cpu/o3/comm.hh (Diff revision 1) -
put '{}' on a separate line. ';' is unnecessary
-
src/cpu/o3/comm.hh (Diff revision 1) -
blank line between methods (here & below)
-
src/cpu/o3/comm.hh (Diff revision 1) -
again optional, but consider
!(*this==that) -
src/cpu/o3/comm.hh (Diff revision 1) -
When do we need ordering of PhysRegIds? Please add a comment here explaining why this is needed. Also, why not just compare _flatIdx?
-
src/cpu/o3/comm.hh (Diff revision 1) -
see my comment on the previous patch on restructuring this expression.
Review request changed
Updated (May 23, 2016, 9:47 a.m.)
Description: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+383 -376) |
