Review Board 2.0.15


gpu-compute: Fixed a bug in global memory pipeline

Review Request #3470 - Created May 18, 2016 and updated

Information
Tuan Ta
gem5
Reviewers
Default

gpu-compute: Global memory pipeline should not increment inflightStores counter for memory fence instruction. Deadlock could happen when there are many fence instructions executed by a compute unit because inflightStores will eventually go over gmQueueSize.


   
Review request changed
Updated (May 19, 2016, 2:30 p.m.)

Summary:

-gpu-compute: Fixed a bug in global_memory_pipeline.cc
+gpu-compute: Fixed a bug in global memory pipeline

Description:

~  

gpu-compute: In VIPER protocol, inflighStores should not be incremented for memory fence instruction. Deadlock could happen when there are many fence instructions executed by a compute unit because inflightStores will eventually go over gmQueueSize.

  ~

gpu-compute: Global memory pipeline should not increment inflightStores counter for memory fence instruction. Deadlock could happen when there are many fence instructions executed by a compute unit because inflightStores will eventually go over gmQueueSize.

Ship it!
Posted (May 19, 2016, 2:40 p.m.)

Thanks, Tuan. I will ship this soon.

Posted (June 6, 2016, 8:39 a.m.)

This was committed, Tuan, so this request may be closed.