misc: add a MasterId to the ExternalPort

Information
Submitter:	Christian Menard
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Blocks:	3527
Reviewers
Groups:	Default
People:

Description

The Request constructor requires a MasterID. However, an external transactor
has no chance of getting a MasterID as it does not have a pointer to the
System. This patch adds a MasterID to ExternalMaster to allow external modules
to easily genrerate new Requests.

Testing Done

Used in a SystemC transactor

Ship It!

Are the examples in /util/tlm and /util/systemc still working with this change?

Andreas Hansson May 29, 2016, 10:50 p.m. (May 29, 2016, 10:50 p.m.)

What is the SystemC license? Should we consider including all/parts in ext/ so that we can always build (and test) this support?

Matthias Jung May 30, 2016, 12:46 a.m. (May 30, 2016, 12:46 a.m.)

Hi Andreas,
SystemC has its own licence, called SystemC Open Source Licence. I don't know if this fits to gem5's BSD licence ...

http://accellera.org/images/about/policies/SystemC_Open_Source_License_v3.3.pdf

Regards
Matthias

Andreas Hansson May 30, 2016, 12:56 a.m. (May 30, 2016, 12:56 a.m.)

Thanks for the pointer.

Seems there are whole book-chapters on this topic(!). Not as easy as I had hoped.

Christian Menard May 30, 2016, 7:29 a.m. (May 30, 2016, 7:29 a.m.)

The Patch has no influence on the examples as /util/systemc does not use external ports and /util/tlm only implements an external TLM slave port. However, I'am working on a external TLM master port, so that I can connect other CPU models to gem5's memory system. I need to generate packets from TLM transactions in the external module and therefore need a MasterID.

Ship It!

Summary:

-	ExternalMaster: add a masterId so that external ports can generate packages
+	misc: add a MasterId to the ExternalPort

Change Summary:

updated the diff: rebased on 11691 and generated with mq

Diff:

Revision 2 (+8 -1)

Show changes

	src/mem/ExternalMaster.py
	src/mem/external_master.hh
	src/mem/external_master.cc

Ship It!

Description:

~		The Request constructor requires a MasterID. However, an external transactor has no chance of getting a MasterID as it does not have a pointer to the System. This patch adds a MasterID to ExternalMaster in order to allow external modules to genrerate Packets.
	~	Changeset 11793:3a8e34a03c9e
	+	---------------------------
	+	misc: add a MasterId to the ExternalPort
	+
	+	The Request constructor requires a MasterID. However, an external transactor
	+	has no chance of getting a MasterID as it does not have a pointer to the
	+	System. This patch adds a MasterID to ExternalMaster to allow external modules
	+	to easily genrerate new Requests.

Branch:

+	default

Diff:

Revision 3 (+11 -1)

Show changes

	src/mem/ExternalMaster.py
	src/mem/external_master.hh
	src/mem/external_master.cc

Description:

~		Changeset 11793:3a8e34a03c9e
	~	misc: add a MasterId to the ExternalPort
-		---------------------------
-		misc: add a MasterId to the ExternalPort

		The Request constructor requires a MasterID. However, an external transactor
		has no chance of getting a MasterID as it does not have a pointer to the
		System. This patch adds a MasterID to ExternalMaster to allow external modules
		to easily genrerate new Requests.

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Summary:

Change Summary:

Diff:

Description:

Branch:

Diff:

Description:

Status: Closed (submitted)