looks good

src/base/debug.hh (Diff revision 1)

It looks like we're not completely consistent on this, but I'd put the close brace in column 0, then put the comment after that, e.g.:

} // namespace Debug

I don't care much about C vs C++-style comments, but having the brace in column 0 seems much more natural since that's where it would be if we weren't commenting it.

Other than that nit (which applies several places), this looks good to me.

1. Nathan Binkert Dec. 22, 2010, 6:12 a.m. (Dec. 22, 2010, 6:12 a.m.)

   I've been doing it this way for years :)  I think the reason that I decided to do it this way is that we chose to *not* have namespaces change the indention level.  I honestly don't care, but there are a ton of examples that look like this, so we should consciously decide on one and change them everywhere and document it.  (Since you brought it up, do you volunteer?  Offering code goes a hell of a long way in a coding debate :)

2. Steve Reinhardt Dec. 22, 2010, 9:42 a.m. (Dec. 22, 2010, 9:42 a.m.)

   Ask and ye shall receive... sometimes, anyway.  FYI, the '//' comments outnumbered the '/*' comments something like 79 to 54, but there was surprising variety in the details ('namespace Foo', 'end namespace Foo', 'Foo namespace').  But hey, stand back, I know regular expressions :-)