src/python/m5/main.py (Diff revision 1)

What is the point of passing in 2 args? so you can have them pre-parsed? Either way a comment is helpful.

src/sim/init.cc (Diff revision 1)

Here too? why do we want weak linking? So you can override it?

src/sim/init.cc (Diff revision 1)

I think this needs a comment

src/sim/init.cc (Diff revision 1)

Since this is technically a pointer, should this be NULL instead of 0?

1. Nathan Binkert Dec. 21, 2010, 8:56 a.m. (Dec. 21, 2010, 8:56 a.m.)

   No.  They're identical.  NULL is a holdover from C where it was typically #defined to (void *)0, but no longer is that the case: http://www2.research.att.com/~bs/bs_faq2.html#null

I second all of Ali's requests for more comments...

src/sim/init.cc (Diff revision 1)

What's our status on non-gcc compilers?  Do we need to hide this in a macro to provide a veneer of portability?  :-)