ruby: rename networktest to garnet_synthetic_traffic.
Review Request #3550 - Created July 13, 2016 and submitted
| Information | |
|---|---|
| Tushar Krishna | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
| ahansson, bbeckman, jyin, mporemba | |
ruby: rename networktest to garnet_synthetic_traffic. networktest is essentially a collection of synthetic traffic patterns for the network. The protocol name and the tester having the same name led to multiple python configuration files with the same name, adding confusion. This patch renames networktest to garnet_synthetic_traffic, and also adds more synthetic traffic patterns.
Posted (July 22, 2016, 4 p.m.)
-
configs/example/garnet_synth_traffic.py (Diff revision 1) -
It would make the command lines slightly more descriptive if this were a "choice" type option. The strings could be converted to ints for the enum on the c++ side.
-
src/cpu/testers/garnet_synthetic_traffic/GarnetSyntheticTraffic.cc (Diff revision 1) -
Could this be parameterized? There may exist some network where this would need to be increased.
-
src/cpu/testers/garnet_synthetic_traffic/GarnetSyntheticTraffic.cc (Diff revision 1) -
fatal("%s deadlocked at cycle %d", name(), curTick()); could be used directly here.
-
src/cpu/testers/garnet_synthetic_traffic/GarnetSyntheticTraffic.cc (Diff revision 1) -
fatal() can be used directly here
Posted (July 22, 2016, 4:38 p.m.)
-
configs/example/garnet_synth_traffic.py (Diff revision 1) -
Please add a comment like: set to -1 to disable
-
configs/example/garnet_synth_traffic.py (Diff revision 1) -
-1 to disable
-
configs/example/garnet_synth_traffic.py (Diff revision 1) -
-1 to disable
-
configs/example/garnet_synth_traffic.py (Diff revision 1) -
Default (-1): inject randomly in all
Review request changed
Updated (Aug. 24, 2016, 8:20 a.m.)
Summary: |
|
|||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
|||||||||||||||||||||||||||
Diff: |
Revision 2 (+770 -661) |
Ship It!
Ship It!