config: make internal links in network topology unidirectional.

Information
Submitter:	Tushar Krishna
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:	ahansson, bbeckman, jyin, mporemba

Description

config: make internal links in network topology unidirectional.
This patch makes the internal links within the network topology
unidirectional, thus allowing any deadlock-free routing algorithms to
be specified from the topology itself using weights.
This patch also renames Mesh.py and MeshDirCorners.py to
Mesh_XY.py and MeshDirCorners_XY.py (Mesh with XY routing).
It also adds a Mesh_westfirst.py and CrossbarGarnet.py topologies.

Testing Done

Issue Summary

Description	From	Last Updated	Status
It seems to me that these four lines should be removed. Will they be useful for anything?	Onur Kayiran	Aug. 23, 2016, 9 p.m.	Resolved
Seems link_count should increment after appending int_links	Jieming Yin	July 23, 2016, 3:12 p.m.	Dropped

configs/topologies/CrossbarGarnet.py (Diff revision 1)

Trailing whitespace

configs/topologies/Mesh_XY.py (Diff revision 1)

Trailing whitespace

configs/topologies/Mesh_XY.py (Diff revision 1)

Trailing whitespace

configs/topologies/Mesh_XY.py (Diff revision 1)

Whitespace

configs/topologies/Mesh_westfirst.py (Diff revision 1)

Trailing whitespace

configs/topologies/Mesh_westfirst.py (Diff revision 1)

Trailing whitespace

configs/topologies/Mesh_westfirst.py (Diff revision 1)

Trailing whitespace

configs/topologies/Mesh_westfirst.py (Diff revision 1)

Trailing whitespace

configs/topologies/Mesh_westfirst.py (Diff revision 1)

Whitespace

src/mem/ruby/network/simple/SimpleNetwork.py (Diff revision 1)

Trailing whitespace

src/mem/ruby/network/simple/SimpleNetwork.py (Diff revision 1)

It seems to me that these four lines should be removed. Will they be useful for anything?

Show all issues

Some minor style issues which you can see on the reviewboard need to be fixed, otherwise looks good.

configs/topologies/Mesh_westfirst.py (Diff revision 1)

Minor nitpick, but this seems like east-first to me, since the links with weight 1 send from west to east. But this all depends how you look at the map :)

Tushar Krishna Aug. 24, 2016, 8:40 a.m. (Aug. 24, 2016, 8:40 a.m.)

These are actually links going from the west output port of the source to the east input port of the dest. So it is West-first. You always try to use the west output port as that has the lowest weight.

I have made this clearer in the new patch by renaming "west_id" to "west_out" and "east_id" to "east_in".

configs/topologies/Pt2Pt.py (Diff revision 1)

Seems link_count should increment after appending int_links

Show all issues

Tushar Krishna July 23, 2016, 3:12 p.m. (July 23, 2016, 3:12 p.m.)

Hmmm link_count is just being used to provide a unique link_id to every link which it is doing right as it is incremented before adding every new link?

Summary:

-	topology: make internal links unidirectional.
+	config: make internal links in network topology unidirectional.

Description:

~		topology: make internal links unidirectional.
	~	config: make internal links in network topology unidirectional.
		This patch makes the internal links within the network topology
		unidirectional, thus allowing any deadlock-free routing algorithms to
		be specified from the topology itself using weights.
		This patch also renames Mesh.py and MeshDirCorners.py to
		Mesh_XY.py and MeshDirCorners_XY.py (Mesh with XY routing).
		It also adds a Mesh_westfirst.py and CrossbarGarnet.py topologies.

Diff:

Revision 2 (+611 -491)

Show changes

	configs/topologies/Cluster.py
	configs/topologies/Crossbar.py
	configs/topologies/CrossbarGarnet.py
	configs/topologies/Mesh.py
	configs/topologies/MeshDirCorners.py
	configs/topologies/MeshDirCorners_XY.py
	configs/topologies/Mesh_XY.py
	configs/topologies/Mesh_westfirst.py
	15 more

Ship It!

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Summary:

Description:

Diff:

Status: Closed (submitted)