config: add port directions and per-router delay in topology.

Information
Submitter:	Tushar Krishna
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:	ahansson, bbeckman, jyin, mporemba

Description

config: add port directions and per-router delay in topology.
This patch adds port direction names to the links during topology
creation, which can be used for better printed names for the links
or for users to code up their own adaptive routing algorithms.
It also adds support for every router to have an independent latency
value to support heterogeneous topologies with the subsequent
garnet2.0 patch.

Testing Done

configs/topologies/Mesh_XY.py (Diff revision 1)

Whitespace

Tushar Krishna July 21, 2016, 10 a.m. (July 21, 2016, 10 a.m.)
```
will fix this.
```

src/mem/ruby/network/BasicLink.py (Diff revision 1)

This variable needs to be the same as the flit size in BaseGarnetNetwork.py in Garnet simulations. Is there an easy way to assign these two variables with the same value?

Tushar Krishna July 21, 2016, 10 a.m. (July 21, 2016, 10 a.m.)

bandwidth_factor is not used by Garnet at all. Bandwidth is modeled in garnet by setting the flit width ...
That is why I added a comment saying only used by simple network.
The reason why this parameter appears in BasicLink.py is because the simple network can allow different bandwidths per link from the topology file.

src/mem/ruby/network/BasicLink.py (Diff revision 1)

Whitespace

Tushar Krishna July 21, 2016, 10 a.m. (July 21, 2016, 10 a.m.)
```
will fix this.
```

It seems odd to modify a bunch of garnet "1.0" files when they are deleted in the next patch in this series. Did I miss something here? Are these files effectively "hg mv" 'd by the next patch?

Tushar Krishna July 23, 2016, 3 p.m. (July 23, 2016, 3 p.m.)

I did that just so that each patch in the series does not break the build. It is possible in theory to just pull up to this patch and use the old garnet code.

Ship It!

Ship It!

Summary:

-	topology: add port directions and per-router delay.
+	config: add port directions and per-router delay in topology.

Description:

~		topology: add port directions and per-router delay.
	~	config: add port directions and per-router delay in topology.
		This patch adds port direction names to the links during topology
		creation, which can be used for better printed names for the links
		or for users to code up their own adaptive routing algorithms.
~		It also lets every router have an independent latency value to
~		support heterogeneous topologies with garnet2.0.
	~	It also adds support for every router to have an independent latency
	~	value to support heterogeneous topologies with the subsequent
	+	garnet2.0 patch.

Diff:

Revision 2 (+57 -12)

Show changes

	configs/topologies/Mesh_XY.py
	src/mem/ruby/network/BasicLink.py
	src/mem/ruby/network/BasicRouter.py
	src/mem/ruby/network/BasicRouter.hh
	src/mem/ruby/network/BasicRouter.cc
	src/mem/ruby/network/Network.hh
	src/mem/ruby/network/Topology.hh
	src/mem/ruby/network/Topology.cc
	6 more

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Summary:

Description:

Diff:

Status: Closed (submitted)