Didn't check it closely, but it looks fine from a quick skim.

Didn't check your logic/math or anything, but looks good...so, this is just like Dist but the buckets change dynamically?  Awesome.

src/base/statistics.hh (Diff revision 1)

Nate, can you add a function that returns the sum?

src/base/statistics.hh (Diff revision 1)

I am using your Histogram class to replace the statistics currently being used in Ruby.

src/base/statistics.hh (Diff revision 1)

This line seems to be incorrect. squares is being updated with val*val*number*number. Should it not be val*val*number?

1. Nathan Binkert Jan. 8, 2011, 2:27 p.m. (Jan. 8, 2011, 2:27 p.m.)

   Good catch.

How to handle vector of histograms? Should we define a new
class similar to VectorDistribution? I have to point out
that Ruby also has a vector of vector of histograms in the
Profiler class.

src/base/statistics.hh (Diff revision 1)

Why do you want this?  Generally, we don't expose the internals of stats and I'm reluctant to do so.

1. Nilay Vaish Jan. 9, 2011, 3:33 a.m. (Jan. 9, 2011, 3:33 a.m.)

   Since the average is being printed, I am fine with not having such a function.

With each bucket, both the name and description of the histogram are printed. I think this is unnecessary. Should each bucket's count be printed in a new line? Again, seems unnecessary to me.