Ruby: Updates MOESI CMP directory protocol
Review Request #359 - Created Dec. 22, 2010 and submitted
| Information | |
|---|---|
| Nilay Vaish | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Ruby: Updates MOESI CMP directory protocol This patch updates the MOESI CMP directory protocol to conform with the new interfaces of CacheMemory and TBETable classes, and the changes in SLICC.
These changes have been tested using the Ruby random tester. The tester was used with -l = 1048576 and -n = 2.
Review request changed
Updated (Dec. 24, 2010, 1:02 a.m.)
Change Summary:
is_valid_cache_entry() and is_valid_tbe() have been removed. These have been replaced with a call to is_valid_ptr(<ptr variable>).
Diff: |
Revision 3 (+305 -259) |
|---|
Review request changed
Updated (Dec. 31, 2010, 9:35 a.m.)
Change Summary:
The changes made were necessitated by the changes made to SLICC and CacheMemory class.
Diff: |
Revision 4 (+381 -369) |
|---|
Posted (Jan. 3, 2011, 2:16 a.m.)
-
src/mem/protocol/MOESI_CMP_directory-L2cache.sm (Diff revision 4) -
As usual, please delete unused code instead of commenting it out.
Review request changed
Updated (Jan. 3, 2011, 6:20 a.m.)
Change Summary:
Removed the code that was commented out in the previous revision.
Diff: |
Revision 5 (+357 -372) |
|---|
Well Done! I have a couple questions just to clarify my understanding of what is going on, but overall this looks great to me.
-
src/mem/protocol/MOESI_CMP_directory-L1cache.sm (Diff revision 8) -
So the assumption here is the L1IcacheMemory.lookup() call either returns the L1I cache entry or NULL/OOD, correct? Does SLICC also support explicitly passing back OOD?
-
src/mem/protocol/MOESI_CMP_directory-L1cache.sm (Diff revision 8) -
This seems like an unrelated change, correct. However it is pretty minor, so don't worry about it.
Review request changed
Updated (Jan. 16, 2011, 8:02 a.m.)
Summary: |
|
||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||||
Branch: |
|
||||||||||||
Diff: |
Revision 9 (+529 -466) |