Add a DmaCallback class to DmaDevice
Review Request #3590 - Created Aug. 4, 2016 and submitted
| Information | |
|---|---|
| Michael LeBeane | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 11555:e72fa7b7cc13
---------------------------
Add a DmaCallback class to DmaDevice
This patch introduces the DmaCallback helper class, which registers a callback
to fire after a sequence of (potentially non-contiguous) DMA transfers on a
DmaPort completes.
Review request changed
Updated (Aug. 4, 2016, 11:44 a.m.)
Summary: |
|
||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
Posted (Aug. 10, 2016, 9:38 a.m.)
This looks good, but I suspect there might be draining issues here. Isn't there a race between a system entering the drained state (DmaPort::handleResp) and calling process? The DmaChunkEvent could potentially get lost in a check point unless the device owning the DmaCallback helper is aware of this. I would suggest that you either implement the Drainable interface in DmaCallback to prevent this from happening or document this behaviour.
Review request changed
Updated (Aug. 16, 2016, 3:31 p.m.)
Summary: |
|
||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||||||||||||||||||||||
Diff: |
Revision 2 (+85) |
Ship It!