util: python implementation of a routine that will sort includes

Information
Submitter:	Nathan Binkert
Repository:	gem5
Branch:
Bugs:
Depends On:
Reviewers
Groups:	Default
People:	ali, gblack, nate, stever

Description

util: python implementation of a routine that will sort includes
I didn't realize that the perl version existed when I started this,
this version has a lot more features than the previous one since it will
sort and separate python, system, and m5 headers in separate groups, it
will remove duplicates, it will also convert c headers to stl headers

Testing Done

One big question I have is, do people like the sorting order.  This went along with what Steve had in his wish list for the perl version, but it isn't as simple as M-x sort-lines anymore.  Of course, people could run this on their code.  I could even plug it into the style hook.

Nathan Binkert Dec. 26, 2010, 1:18 a.m. (Dec. 26, 2010, 1:18 a.m.)

One other question is, should we separate out automatically generated headers?  (like those for params and soon, debug flags?)  If so, should I rename them at all, put them in a subdirectory (generated/params/Foo.hh), or leave them alone?  Given that there is going to be a bunch of churn, we may as well do it all at once.

I'll try to add the sorting function to the style hook, but that will be later.  I probably need to do a bit of work to make the commit hook work better for some people anyway.  Do people have it enabled generally?

I think we've beat this to death on the mailing list. My only comment is that before it becomes part of the commit hook, please make sure that you can't throw anything at it that will cause an exception.

Diff:

Revision 5 (+302 -91)

Show changes

	util/file_types.py
	util/sort-includes
	util/sort_includes.py

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Diff: