misc: Adds a warning in case gdb is attached multiple times
Review Request #3635 - Created Sept. 27, 2016 and submitted
| Information | |
|---|---|
| Alexandru Dutu | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 11654:46ce6e3222ec --------------------------- misc: Adds a warning in case gdb is attached multiple times Instead of scheduling another event, this patch adds a warning in case gdb is attached multiple times and the first attachement event has not been processed yet.
Regressions pass.
Ship It!
Posted (Oct. 3, 2016, 4:06 a.m.)
Wouldn't it make more sense to just disallow multiple GDB clients to be attached at the same time?
Doesn't look like "gdb" is one of our approved keywords. Maybe misc? http://gem5.org/Submitting_Contributions#Commit_Messages
Review request changed
Updated (Oct. 3, 2016, 12:49 p.m.)
Summary: |
|
||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||||||||||||||||
Diff: |
Revision 2 (+5) |
-
src/base/remote_gdb.cc (Diff revision 2) -
Could you make this a bit more descriptive before submitting it? Something like "A GDB trap event has already been scheduled, ignoring second event."
No need for a second review though.
