arm, config: Enabled MemConfig usage for the example big.LITTLE
Review Request #3665 - Created Oct. 14, 2016 and updated
| Information | |
|---|---|
| Anastasiia Butko | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 11687:7b83be200f9e
---------------------------
arm, config: Enabled MemConfig usage for the example big.LITTLEThis patch replaces the SimpleMemory with the MemConfig
function. Additional parser arguments are added
(TODO: improve with addCommonOptions & addFSOptions).Reported-by: Anastasiia Butko <abutko@lbl.gov>
Reviewed-by: Andreas Sandberg <andreas.sandberg@arm.com>
Reviewed-by: Jason Lowe-Power <jason@lowepower.com>
Thanks for submitting this! The change looks good other than a coupld of redundant imports.
-
configs/example/arm/fs_bigLITTLE.py (Diff revision 1) -
These two imports aren't needed.
One small thing and a comment below.
-
configs/example/arm/fs_bigLITTLE.py (Diff revision 1) -
There's no change needed here. However, this is a potential problem in the future. We're basically re-creating the options that are in configs/common/Option.py:addCommonOptions(). I don't think there is a simple solution to this right now, but we need to think about a fix for this in the future.
-
configs/example/arm/fs_bigLITTLE.py (Diff revision 1) -
Triple quotes aren't necessary here.
Description: |
|
||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+21 -6) |
Ship It!
Ship It!
Description: |
|
|||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+21 -6) |