gpu-compute: fix segfault when constructing GPUExecContext
Review Request #3692 - Created Nov. 1, 2016 and submitted
| Information | |
|---|---|
| Tony Gutierrez | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 11889:b236bb4bd2ce --------------------------- gpu-compute: fix segfault when constructing GPUExecContext the GPUExecContext context currently stores a reference to its parent WF's GPUISA object, however there are some special instructions that do not have an associated WF. when these objects are constructed they set their WF pointer to null, which causes the GPUExecContext to segfault when trying to dereference the WF pointer to get at the WF's GPUISA object. here we change the GPUISA reference in the GPUExecContext class to a pointer so that it may be set to null.
Review request changed
Updated (Nov. 1, 2016, 3:55 p.m.)
Description: |
|
||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+6 -4) |
This fixed some problems I've seen when running.
Posted (Nov. 21, 2016, 11:31 a.m.)
Any other thoughts? Plan on shipping this today.
