syscall_emul: return -errno on a failed close call

Download Diff
View Diff

Information
Submitter:	Brandon Potter
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 11727:e576e1bd7cd6
---------------------------
syscall_emul: return -errno on a failed close call

Testing Done

Expand All
Collapse All

Ship It!

BTW, how are you finding all these bugs? Do you have some test suite you're running which exercises all of these syscalls?

Brandon Potter Nov. 16, 2016, 11:12 a.m. (Nov. 16, 2016, 11:12 a.m.)

No, I don't have a test suite for it.

It's not really a bug in that it wouldn't do the "right" thing either; it's just that we have the convention or returning -errno for failed system calls. I don't know why it was missing from the code in the first place.

You have a pending review.

Review Board 2.0.15

This change has been discarded.

Screenshots

Files

Status: Discarded