commit 752c67b134f4cb0b7ca68a907c39a5a482de30b3
Review Request #3708 - Created Nov. 16, 2016 and submitted
| Information | |
|---|---|
| Rahul Thakur | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 11705:f55d4a414fa1
---------------------------
commit 752c67b134f4cb0b7ca68a907c39a5a482de30b3
Author: Rahul Thakur <rjthakur@google.com>
Date: Thu Oct 27 17:44:40 2016 -0700
mem: Add memory footprint probe
Change-Id: I0fba8995edd63df4ef49969347be6d2aefceca9f
Looks good. You might want to consider changing the way the reset callback is created to remove an unnecessary class though.
-
src/mem/probes/mem_footprint.cc (Diff revision 1) -
You could actually do this instead of using a custom class:
registerResetCallback(new MakeCallback<MemFootprintProbe, &MemFootprintProbe::statReset>(this))
Review request changed
Updated (Nov. 17, 2016, 12:02 p.m.)
Description: |
|
|||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+282) |
Ship It!
Ship It!
Ship It!
Ship It!