Ship It!

src/mem/ruby/network/garnet2.0/GarnetNetwork.py (Diff revision 2)

what is the unit?
if it is time we should not use Uint

Show all issues

1. Jieming Yin Nov. 17, 2016, 2:58 p.m. (Nov. 17, 2016, 2:58 p.m.)

   It is not time. It's more like attempts--after failing allocating a virtual channel for this many times, the NI reports a potential deadlock.

src/mem/ruby/network/garnet2.0/GarnetNetwork.py (Diff revision 2)

what is the unit?

Show all issues

src/mem/ruby/network/garnet2.0/NetworkInterface.cc (Diff revision 2)

just do it in the initialisation list

Show all issues

src/mem/ruby/network/garnet2.0/NetworkInterface.cc (Diff revision 2)

this should not be a panic, perhaps a fatal?

Show all issues

1. Jieming Yin Dec. 1, 2016, 3:37 p.m. (Dec. 1, 2016, 3:37 p.m.)

   I think here should be a panic, since it's not an error caused by user. If the condition satisfies, it is very likely to be a garnet routing problem.

2. Andreas Hansson Dec. 2, 2016, 4:22 a.m. (Dec. 2, 2016, 4:22 a.m.)

   Usually panic is for issues caused by a bug/error in the simulator itself. As you say, fatal is configuration/user related.
   In this case I guess its somewhere in between. It is a bug in a protocol, not the simulator itself. I'm fine with either.

src/mem/ruby/network/garnet2.0/NetworkInterface.cc (Diff revision 2)

seems the arguments are wrong?
curTick should also be llu if I remember correctly

Show all issues

configs/network/Network.py (Diff revision 2)

500,000 seems like a pretty large threshold value in my opinion, whatever be the size of the network.

It means no packet left the router connected to the NI for 500K cycles.

I think we can make it 50,000.

Show all issues

Ship It!