Posted (Jan. 6, 2011, 9:17 p.m.)
-
configs/common/FSConfig.py (Diff revision 1) -
How is this different from the generic makeX86System (or similarly named) function this was copied from? Duplicated code, especially so much of it, is bad news. If somebody needed to tweak the MP tables, and forgot to update both places, they'd get different behavior depending on if they had Ruby turned on. The only ruby-esque line I see is the like about dma_devices, and that's commented out. As a side issue that should be deleted, not commented out.
-
configs/common/FSConfig.py (Diff revision 1) -
I don't think everyone that will use this config will have this file, and also not everyone that uses Ruby will be using it with parsec.
