I'm confused.  These work completed functions are following the same convention as other pseudo instructions that involve the thread context.  Both sets of functions do most of their logic in pseudo_inst.  Why should the guts of the work functions be moved to system?  Or are you suggesting a different change?

I'm not suggesting that they're moved to system. I'm just saying that they need a good comment that describes their purpose and use. 

I added a few more comments, but I'm not sure if it is what you are looking for.  It seems a little overkill to put more any comments into pseudo_inst.cc, since no other functions in this file are commented at all.  I do agree that we need to document on the wiki about how to use these annotations.  I think we should include that in our planned overhaul of the wiki, since I don't see a good place to put it right now.  Please let me know if you have a good suggestion. 

Thanks. Looks good to me. I realize that there aren't any other instructions in there that are documented, but I think that is an oversight. After digging through src/base it became clear to me that we write code knowing exactly what it does and what it should be used for and then forget about it. I think the comments you created would actually be better as doxygen comments in system.hh for incWorkItemsBegin() incWorkItemsEnd() and markWorkItem(). Both places might be good.

Thanks again.