Ruby: Remove libruby
Review Request #439 - Created Jan. 25, 2011 and submitted
| Information | |
|---|---|
| Nilay Vaish | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Ruby: Remove libruby This patch removes libruby from Ruby. It is no longer required. The structures defined in this file have been moved to slicc_interface/RubyRequest.hh file.
Posted (Jan. 25, 2011, 1:50 a.m.)
The code in storebuffer.cc looks pretty suspect. Where it was looking for something from libruby, you replaced that by a zero. Seems that the code won't work anymore in that case. If this is correct, then the code is very confusing and a little bit of cleanup would be warranted.
-
src/mem/ruby/storebuffer/storebuffer.cc (Diff revision 1) -
Is this right? My guess is that the entire "if (!m_use_storebuffer) { }" block should be replaced by an "if (!m_use_storebuffer) fatal("must provide a storebuffer in the configuration")" or something like this. I don't see how this could work without a storebuffer. -
src/mem/ruby/storebuffer/storebuffer.cc (Diff revision 1) -
fatal() ? Isn't a storebuffer required?
-
src/mem/ruby/storebuffer/storebuffer.cc (Diff revision 1) -
panic?
-
src/mem/ruby/storebuffer/storebuffer.cc (Diff revision 1) -
panic?
Review request changed
Updated (Feb. 25, 2011, 12:32 a.m.)
Summary: |
|
|||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
|||||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 2 (+206 -509) |
