Review Board 2.0.15


X86: Change how the default disk image gets set up.

Review Request #456 - Created Jan. 29, 2011 and submitted

Information
Gabe Black
gem5
Reviewers
Default
ali, gblack, nate, stever 
X86: Change how the default disk image gets set up.

The disk image to use was always being forced to a particular value. This
change changes what disk image is selected as the default based on the
architecture being built. In the future, a more sophisticated system might be
used that selected a path based on certain rules instead of relying on one off
file names.

   

  


 


 

  

  









  
 


  

 


















 

  


 


  



   

   
Ali Saidi

   
Posted  (Jan. 30, 2011, 9:26 a.m.)


  


  


  

   



  

   

   
    
    
   


  




   







    

     
     

      

       
        

         
          configs/common/Benchmarks.py
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


       
      

     

    

    


     
What about naming all the images the same (e.g. linux.img) and changing disk(...) to insert a target ISA?





  

   

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    I intend to do that, but in a later change. I don't want to hold up getting the X86_FS regressions in there.
    
    
    
   
    2. 

   


  


    


   



  

 


  

 

















 



 

  


 


  



   

   
Nathan Binkert

   
Posted  (Feb. 2, 2011, 4:59 a.m.)


  


  


  

   
If this commit is truly a stopgap, I'm OK, but this sort of thing tends to live forever and I'd hate for that to happen.