Review Board 2.0.15


M5: Don't include isa_traits.hh and use the TheISA namespace unless really needed.

Review Request #481 - Created Feb. 11, 2011 and submitted

Information
Ali Saidi
gem5
Reviewers
Default
ali, gblack, nate, stever 
M5: Don't include isa_traits.hh and use the TheISA namespace unless really needed.

   

  


 


 

  

  









  
 


  

 
















 



 

  


 


  




   
Ship it!



   

   
Nathan Binkert

   
Posted  (Feb. 11, 2011, 11:44 a.m.)


  


  


  

   
Love it.  Assuming that this compiles properly for *all* possible ISAs and emulations. Go for it.

"M5:" is not particularly descriptive.  Perhaps "includes:"?



  

   

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    I agree.
    
    
    
   
    2.