Seems like a reasonable idea to me, but a Ruby person has to agree.

src/mem/ruby/buffers/MessageBuffer.cc (Diff revision 1)

If you're going to change this, you should change it to a ccprintf :)  Totally not necessary if you don't feel like it.

src/mem/ruby/network/simple/PerfectSwitch.hh (Diff revision 1)

probably not worth storing m_name.  You may as well just generate it in name().

src/mem/ruby/network/simple/PerfectSwitch.cc (Diff revision 1)

IMHO, You may as well just stick this in the header.

src/mem/ruby/network/simple/Throttle.hh (Diff revision 1)

Please put system headers above M5 headers.

src/mem/ruby/network/simple/Throttle.hh (Diff revision 1)

Same as above.

src/mem/ruby/network/simple/Throttle.cc (Diff revision 1)

header file.

src/mem/ruby/buffers/MessageBuffer.hh (Diff revision 2)

You have random whitespace here.  Please remove it.

src/mem/ruby/buffers/MessageBuffer.cc (Diff revision 2)

How does the name get set now?

1. Korey Sewell Feb. 22, 2011, 4:16 a.m. (Feb. 22, 2011, 4:16 a.m.)

   This was an error, I shouldnt have taken this out.

src/mem/ruby/buffers/MessageBuffer.cc (Diff revision 2)

no space after \n

src/mem/ruby/network/simple/PerfectSwitch.hh (Diff revision 2)

use csprintf()

src/mem/ruby/network/simple/Throttle.hh (Diff revision 2)

System includes before M5 includes

src/mem/ruby/network/simple/Throttle.hh (Diff revision 2)

csprintf()

src/mem/ruby/network/simple/Throttle.cc (Diff revision 2)

ccprintf()

1. Korey Sewell Feb. 22, 2011, 4:26 a.m. (Feb. 22, 2011, 4:26 a.m.)

   In general, is it just a matter of preference or M5 style to do {cc/cs}printf where possible instead of concatenating strings or using multiple extraction operators?
   
   I can fix this one line for Ruby, but unfortunately a lot of the imported Ruby code likes that format so maybe that should be a separate change where somebody goes through and updates all of the "out << ..." to ccprintfs.

2. Nathan Binkert Feb. 22, 2011, 4:59 a.m. (Feb. 22, 2011, 4:59 a.m.)

   cprintf is generally easier to read and write, so it is preferable.  I'd also generally prefer not to use to_string when csprintf is a better choice.  In general, I don't think you need to change operator<< stuff to cprintf, though if you're already editing the code and it doesn't disrupt the flow, you may as well do it.  Some day I'll go through and to a massive source update, but it's pretty low on the list.