Review Board 2.0.15


O3: Cleanup the commitInfo comm struct.

Review Request #510 - Created Feb. 25, 2011 and submitted

Information
Ali Saidi
gem5
Reviewers
Default
ali, gblack, nate, stever
O3: Cleanup the commitInfo comm struct.

Get rid of unused members and use base types rather than derrived values
where possible to limit amount of state. This cleans up a change to the
fetch stage I promised Steve a month ago.

   
Posted (Feb. 26, 2011, 8:48 a.m.)
I don't see anything obviously wrong here, although I'm sure it wouldn't be hard to slip a bug into this code accidentally. Please be sure to run all the regressions just in case.
  1. They all run. I was very careful when I did it, so I believe it is correct.
src/cpu/o3/comm.hh (Diff revision 1)
 
 
You have two sentences mushed together here.
  1. yup.
Ship it!
Posted (March 2, 2011, 1:25 a.m.)
Thanks, Ali!