Looks fine. Two things though: 1) The documentation on the wiki needs to be updated along with this change. 2) I would like a separate email sent to the list saying that update_refs -> UPDATE_REFS.
Posted (March 2, 2011, 1:21 a.m.)
I'm willing to be convinced on this one, but I'd argue that the inconsistency is that VERBOSE should be lowercase, not that update_ref should be uppercase... I think I originally made update_ref lowercase to distinguish it from the sticky args that control the build itself, where the non-sticky vars are more like --foo command-line options (conceptually if not syntactically). Just some historical perspective from the guy who introduced update_ref.
Review request changed
Updated (March 2, 2011, 6:45 p.m.)
Diff: |
Revision 2 (+2 -2) |
|---|
