sim: Fixes Simulation.py to allow more than 1 core for standard switching.
Review Request #564 - Created March 11, 2011 and submitted
| Information | |
|---|---|
| Tony Gutierrez | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
| ali, gblack, nate, stever | |
sim: Fixes Simulation.py to allow more than 1 core for standard switching. This patch moves the assignment of testsys.switch_cpus, testsys.switch_cpus_1, switch_cpu_list, and switch_cpu_list1 outside of the for loop so they are assigned only once, after switch_cpus and switch_cpus_1 are constructed.
Posted (March 11, 2011, 4:21 a.m.)
Can you comment on why the current code is broken in the commit message? It's not immediately obvious to me.
Review request changed
Updated (March 11, 2011, 7:09 a.m.)
Description: |
|
|---|
I haven't verified it myself, but it looks correct by inspection.
I was pretty confused until I realized that the reviewboard web interface doesn't highlight whitespace changes, so the significant part about the assignments moving outside the loop (which was a simple matter of changing their indent level) doesn't show up. It looks like those assignments never should have been inside the loop anyway.