isa: get rid of expandForMT function

Information
Submitter:	Korey Sewell
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:	ali, gblack, nate, stever

Description

isa: get rid of expandForMT function
MIPS is the only ISA that cares about having a piece of ISA state integrate
multiple threads so add constants for MIPS and relieve the other ISAs from having
to define this. Also, InOrder was the only core that was actively calling
this function
* * *
isa: get rid of corespecific type
The CoreSpecific type was used as a proxy to pass in HW specific params to
a MIPS CPU, but since MIPS FS hasnt been touched for awhile, it makes sense
to not force every other ISA to use CoreSpecific as well use a special
reset function to set it. That probably should go in a PowerOn reset fault
 anyway.

Testing Done

Description:

		isa: get rid of expandForMT function
~		- MIPS is the only ISA that cares about having a piece of ISA state integrate
	~	MIPS is the only ISA that cares about having a piece of ISA state integrate
		multiple threads so add constants for MIPS and relieve the other ISAs from having
~		to define this.
~		- Move code that was formerly there for MIPS and place it in the init function
	~	to define this. Also, InOrder was the only core that was actively calling
	~	this function
	+
	+
	+
	+	isa: get rid of corespecific type
	+	The CoreSpecific type was used as a proxy to pass in HW specific params to
	+	a MIPS CPU, but since MIPS FS hasnt been touched for awhile, it makes sense
	+	to not force every other ISA to use CoreSpecific as well use a special
	+	reset function to set it. That probably should go in a PowerOn reset fault
	+	anyway.

Diff:

Revision 2 (+34 -141)

Show changes

	src/arch/alpha/isa.hh
	src/arch/alpha/types.hh
	src/arch/arm/types.hh
	src/arch/mips/isa.hh
	src/arch/mips/isa.cc
	src/arch/power/types.hh
	src/arch/sparc/types.hh
	src/arch/x86/types.hh
	4 more

I think this is a great change. There are only a couple small things to look at, and then of course making sure the regressions still work. I expect they will, but this touches a lot of areas so it's best to be sure.

src/arch/mips/isa.hh (Diff revision 2)

Do you really want these to be static? Then they can't be changed between different CPUs which have separate ISA state. I can see how you might be treating them as constants, but I'm not familiar enough with MIPS to know if that makes sense.

Korey Sewell March 15, 2011, 4:55 a.m. (March 15, 2011, 4:55 a.m.)

That's a good point. 

I suppose I could give the constructor for the MIPS ISA some default parameters that would just automatically set the variables.

something like "ISA(uint8_t num_threads = 1, uint8_t num_vpes = 1)" could work.

src/arch/mips/isa.cc (Diff revision 2)

This should be a panic, not an assert which will always be triggered.

Diff:

Revision 3 (+57 -158)

Show changes

	src/arch/alpha/isa.hh
	src/arch/alpha/types.hh
	src/arch/arm/types.hh
	src/arch/mips/isa.hh
	src/arch/mips/isa.cc
	src/arch/mips/types.hh
	src/arch/power/types.hh
	src/arch/sparc/types.hh
	5 more

Looks good. Thanks for fixing it up.

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Description:

Diff:

Diff: