Review Board 2.0.15


ISA parser: Set up op_src_decl and op_dest_decl for pc operands.

Review Request #587 - Created March 17, 2011 and submitted

Information
Gabe Black
gem5
Reviewers
Default
ali, gblack, nate, stever 
ISA parser: Set up op_src_decl and op_dest_decl for pc operands.

   

  


 


 

  

  









  
 


  

 


















 

  


 


  




   
Ship it!



   

   
Ali Saidi

   
Posted  (March 17, 2011, 10:27 a.m.)


  


  


  

   



  

   

   
    
    
   


  





  

 


  

 

















 



 

  


 


  



   

   
Korey Sewell

   
Posted  (March 17, 2011, 11:09 a.m.)


  


  


  

   



  

   

   
    
    
   


  




   







    

     
     

      

       
        

         
          src/arch/isa_parser.py
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


       
      

     

    

    


     
Hi Gabe, not to be nitpicky but what are you trying to accomplish with this change? 

I have no objection to it, I'm just trying to understand how this applies to a particular line of code in defining an instruction. 

Is there a short example you can provide that demonstrates what kind of ISA-description you will be able to use with this?




  

   

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    This fixes a bug in the earlier support I added that integrates the new PCState stuff into the ISA parser. If you use op_decl then everything would be fine, but if you use op_src_decl or op_dest_decl then the declaration I'm adding in here will be missing and it won't compile. I was adding some code as part of some other work I'm doing and ran into this, and the fix can be applied independently of that other code.
    
    
    
   
    2.