Since there have been no objections, I'm going to commit this.

src/arch/x86/linux/linux.hh (Diff revision 1)

These RUSAGE and RLIMIT constants come from generic header files in Linux, not one specific to X86. If they aren't there already, they should be in a base class, not an x86 (or especially a 64 bit x86) subclass.

1. Marc Orr May 11, 2012, 10:26 a.m. (May 11, 2012, 10:26 a.m.)

   I've address this in a newly submitted patch (since I can't update this one).

src/arch/x86/linux/linux.hh (Diff revision 1)

This constant is wrong according to http://lxr.linux.no/linux+*/include/asm-generic/resource.h#L26. This should be NPROC. Similarly 7 is NOFILE, 8 is MEMLOCK, and 9 is AS (VMEM doesn't seem to exist). There are some others which have been left out.

1. Marc Orr May 11, 2012, 10:26 a.m. (May 11, 2012, 10:26 a.m.)

   I've address this in a newly submitted patch (since I can't update this one).

src/arch/x86/linux/linux.hh (Diff revision 1)

The indentation here is off.

1. Marc Orr May 11, 2012, 10:26 a.m. (May 11, 2012, 10:26 a.m.)

   I've address this in a newly submitted patch (since I can't update this one).

src/arch/x86/linux/linux.hh (Diff revision 1)

These constants also need to be fixed, or removed if the 64 bit versions get promoted to a base class.

1. Marc Orr May 11, 2012, 10:26 a.m. (May 11, 2012, 10:26 a.m.)

   I've address this in a newly submitted patch (since I can't update this one).