Review Board 2.0.15


configs: combine ruby_se.py and se.py to avoid all that code duplication

Review Request #600 - Created March 18, 2011 and submitted

Information
Lisa Hsu
gem5
Reviewers
Default
ali, gblack, nate, stever
configs: combine ruby_se.py and se.py to avoid all that code duplication

   
Posted (March 18, 2011, 11:17 a.m.)



  
configs/example/se.py (Diff revision 1)
 
 
I applaud getting rid of the duplication, but isn't it a little dangerous here to set up a fake TimingSimpleCPU class and to ignore the se.py options? Maybe you should have a warning if the options don't match what you're forcing? That would avoid any potential confusion.

Alternatively it might make sense to factor out the common parts of this script into a bunch of stuff that other people can use in an se.py like script of their own. That would be nice in the long term, but getting rid of all that code is still great right now.
  1. Yeah, that's true, though the original ruby_se.py did the same thing.  I'll put in a warning if there's a mismatch.