sim: typecast Tick to UTick for eventQ assert

Information
Submitter:	Korey Sewell
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:	ali, gblack, nate, stever

Description

sim: typecast Tick to UTick for eventQ assert

Testing Done

This passed the simple-atomic, simple-timing, and o3 regressions tests for ARM_FS.

src/sim/pseudo_inst.cc (Diff revision 1)

should this really be:
cpu->nextCycle(curTick() + ticks(1))???

I'm thinking that the original code didn't schedule on the Tick boundary but still had the effect of executing after all CPU events would be finished (e.g. CPU tick on 500 and then quiesce event on tick 501 instead of say 1000).

Summary:

-	sim: use nextCycle() for quiesceSkip function
+	sim: typecast Tick to UTick for eventQ assert

Description:

~		sim: use nextCycle() for quiesceSkip function
	~	sim: typecast Tick to UTick for eventQ assert
-		the increment of curTick causes some compiler to complain on an assert in the event queue
-		scheduler. Since the code is only scheduling for the next cycle it seems safe to go ahead
-		and just use the cpu's function to trick the compiler. NOTE: this only comes up in opt/debug
-		builds since asserts are taken out of fast

Diff:

Revision 2 (+1 -1)

Show changes

src/sim/eventq.hh

src/sim/eventq.hh (Diff revision 2)

Can you add a comment here explaining why you you're casting to UTick?

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Summary:

Description:

Diff: