It looks like you accidentally dropped one of the changes between the first and second versions of the diff. It would be a good idea to post those separately anyway so we can discuss them separately. Don't worry about having the extra review in the system even for these relatively short patches. Also, I'm assuming since this is really two patches that your commit messages would/will be different, but the rule is that the first line is a tag with an ":" at the end and then a one line summary. Something like

Foo: Add bar to our foo support.

blah blah, all about the change, blah blah

src/SConscript (Diff revision 2)

I would have thought that only the first part of the if were necessary.  Why are you checking if extra_dir is in BUILDROOT?

Please move the comment to the next line as we have a rule limiting lines to 80 characters.

1. brad danofsky March 26, 2011, 4:03 a.m. (March 26, 2011, 4:03 a.m.)

   I will fix the comment so that the line length is 80 char.
   What I'm trying to do is:
   1) using the "reserved" name "build" I want do check if the build directory and the extra_dir share the same hierarchy
   2) if they do then do not step into a directory named "build"
   3) if the build and extra_dir do not share the same directory hierarchy then go ahead and allow the name build to be used